Don't assign to ::Timer #1227
Merged
Don't assign to ::Timer #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in 1595e6f moved the definition of Timer out of the module definition so that the global ::Timer was mistakenly being defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in 1595e6f moved the definition of Timer out of the Faraday module definition so that it was being defined in the root namespace. I don't think that was the intention of #1205 where that patch was introduced.
This changes the definition from
::Timerto::Faraday::Timer.I discovered this when a separately defined
::Timerin my app was overridden in Faraday v1.2.0